Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rust repository setup to a new Skylark file. #45

Merged
merged 2 commits into from
Apr 28, 2017
Merged

Move rust repository setup to a new Skylark file. #45

merged 2 commits into from
Apr 28, 2017

Conversation

katre
Copy link
Member

@katre katre commented Apr 7, 2017

No description provided.

@davidzchen
Copy link
Member

Can you please take a look at the build failure?

The change itself looks reasonable. For my understanding, what is the background for this?

@katre
Copy link
Member Author

katre commented Apr 25, 2017

Fixed the rustlib vs rust_lib issue.

@katre
Copy link
Member Author

katre commented Apr 25, 2017

The background is the work I am doing in Bazel on platforms and toolchains. This is a pre-requsite to adding a rust_toolchain rule and having that be used with Bazel.

The actual toolchain part will have to wait for several releases until the feature is released, but I am using this as a test case (see https://github.com/katre/rules_rust/tree/02-rust-toolchain-rule for the rust_toolchain rule itself).

@davidzchen
Copy link
Member

Understood. Thanks!

Copy link
Member

@davidzchen davidzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidzchen davidzchen merged commit 442276a into bazelbuild:master Apr 28, 2017
@katre katre deleted the 01-new-repository-setup branch April 28, 2017 13:40
@mattmoor
Copy link

This broke a whole bunch of documentation, because this no longer works:

load("@io_bazel_rules_rust//rust:rust.bzl", "rust_repositories")

I would recommend simply loading rust_repositories into rust.bzl for backwards-compatibility.

@katre
Copy link
Member Author

katre commented Oct 10, 2017

This has been merged since April. I'll send a PR to update the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants